Problem/Motivation

When carrying out an import of an iCal, I get this warning logged:

Deprecated function: auto_detect_line_endings is deprecated in ICal\ICal->__construct() (line 500 of /vendor/johngrogg/ics-parser/src/ICal/ICal.php)

This is deprecated in PHP 8.1.

The call to ICal is coming from IcalParser.

Steps to reproduce

Run an iCal feeds importer on a site using PHP 8.1.

Proposed resolution

Remove the use of this deprecated function. Not clear whether there is functionality lost in doing that which would need to be replaced.

Issue fork feeds_ical-3379345

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ryanrobinson_wlu created an issue. See original summary.

ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented
Assigned: Unassigned » ben.hamelin

Looks like we need to up the version requirement for johngrogg/ics-parser to ^3
https://github.com/u01jmg3/ics-parser/issues/325

ben.hamelin opened merge request !7

ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented
Version: 2.0.6 » 2.1.0
Status: Active » Fixed

@ryanrobinson_wlu Thanks for opening this up. I've just tagged a new release 2.1.0 that updates the requirement for johngrogg/ics-parser.
Can you confirm this updated version resolves your issue?

ryan-l-robinson’s picture

ryan-l-robinson commented

@ben.hamelin Looks good in my first test! Thanks for fixing this and making a release so fast.

ben.hamelin’s picture

ben.hamelin
he/him
Primary language English
Location Adirondack Mountains, NY
commented
Status: Fixed » Closed (fixed)

You bet, glad it's working for you!