Problem/Motivation

The simplesamlphp auth module has an option to show a link on the user login page that links to the SAML redirect URL. Would be nice to have that in this module.

Steps to reproduce

Proposed resolution

Issue fork samlauth-3379033

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

DrIPA created an issue. See original summary.

roderik’s picture

Status: Active » Needs review

Thanks. This looks like a "why wasn't this done before?" type of thing.

(Likely just because noone explicitly requested it until now / I didn't bother to think of a 'generalized' solution. But

  • if it helps the simplesamlphp_auth people coming on board, that's enough reason.
  • Also, a link with a CSS class actually looks like a general enough solution.)

I'm going to use this issue to muck around with the Gitlab comment and merge system -- which I haven't used much yet. I'm seeing something that likely should be changed, but I'll likely do that myself and merge it. (And, in a break with this module's history, I might even add a test.)

roderik’s picture

Status: Needs review » Fixed

Personal conclusion: there are some fairly basic things which I was yeats behind on:

  • Using gitlab to review and merge MRs.
  • Translatability of configuration values. This module doesn't do that properly yet! (It should be translating the existing menu item titles too.) I'll fix that separately.
  • Purging something like a form from the cache, when configuration is re-saved. (I'm sure I have dug into it before, but now I'll remember.)

Thank you for this addition!

  • roderik committed 5ed27f5b on 8.x-3.x authored by DrIPA
    Issue #3379033 by DrIPA, roderik: Add "SSO login link" on the user login...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.