Unable to close mobile menu after clicking the humbug button

You reproduce this on mobile screen

humbug button should work as toggle.

CommentFileSizeAuthor
#10 Changes after applying the patche#4.png171.31 KBTshewang Gyaltshen
#9 afterpatch.png65.7 KBbhupendra_raykhere
#7 Screenshot from 2023-08-16 12-37-53.png47.77 KBakshay kashyap
#6 Screenshot 2023-08-16 120352.png21.25 KBsonam_sharma
#6 Screenshot 2023-08-16 120333.png32.86 KBsonam_sharma
#4 hamburger-open.png606.05 KBakshay kashyap
#4 hamburger.png685.48 KBakshay kashyap
#4 3378634-fix-close-mobile-menu-4.patch2.92 KBakshay kashyap
bug.png272.18 KBdjsagar

Issue fork rhythm-3378634

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

djsagar created an issue. See original summary.

akshay kashyap’s picture

akshay kashyap commented
Assigned: Unassigned » akshay kashyap

Tshewang Gyaltshen made their first commit to this issue’s fork.

akshay kashyap’s picture

akshay kashyap commented
StatusFileSize
new 3378634-fix-close-mobile-menu-4.patch2.92 KB
new hamburger.png685.48 KB
new hamburger-open.png606.05 KB

I have created a Patch to fix the hamburger mobile menu. Please review

akshay kashyap’s picture

akshay kashyap commented
Status: Active » Needs review
sonam_sharma’s picture

sonam_sharma commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot 2023-08-16 120333.png32.86 KB
new Screenshot 2023-08-16 120352.png21.25 KB

I have checked patch #4
It doesn't applied successfully

akshay kashyap’s picture

akshay kashyap commented
StatusFileSize
new Screenshot from 2023-08-16 12-37-53.png47.77 KB

Please check the screenshot I am able to apply the patch successfully.

Tshewang Gyaltshen opened merge request !9

bhupendra_raykhere’s picture

bhupendra_raykhere commented
StatusFileSize
new afterpatch.png65.7 KB

Hi @akshay kashyap,
I have tested your patch #4 on drupal 10. it's not applied successfully, You can see screenshot for your reference.

Tshewang Gyaltshen’s picture

Tshewang Gyaltshen commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new Changes after applying the patche#4.png171.31 KB

Thank you for your patch. I have tested your patch #4 its working. The issue for the mobile view of humburger menu has been fixed after applying your patch.

sonam_sharma’s picture

sonam_sharma commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.