mb_strtolower passing null to parameter ($string) of type string

Deprecated function: mb_strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\request_parameter_condition\Plugin\Condition\RequestParameter->evaluate() (line 154

I suggest inserting to use null coalescing operator to avoid these kind of deprecations

CommentFileSizeAuthor
#2 request_parameter_condition-passing_null_deprecated-3378382-1.patch1.16 KBp-neyens

Issue fork request_parameter_condition-3378382

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

p-neyens created an issue. See original summary.

p-neyens’s picture

p-neyens commented
Assigned: p-neyens » Unassigned
Status: Needs work » Needs review
StatusFileSize
new request_parameter_condition-passing_null_deprecated-3378382-1.patch1.16 KB
keshavv’s picture

keshavv commented
Status: Needs review » Reviewed & tested by the community

I have reviewed the patch. As it is a small change and will work well. We can go with the change.

liam morland made their first commit to this issue’s fork.

liam morland opened merge request !2

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Version: 8.x-2.3 » 8.x-2.x-dev

I created a merge request with the patch in #2.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.