Problem/Motivation

Tabs dropdown button styling does not look good on mobile view. See the screenshot for reference.

Steps to reproduce

  1. Install the theme
  2. Go to any node
  3. Switch to mobile view
  4. See the dropdown button styling

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 MR22-Error.png64.12 KBkanchan bhogade
#9 after_tabs_dropdown_button.mp4247.49 KBesha_kundu
#9 before_dropdown_button_tabs.mp4235.35 KBesha_kundu
#9 after_tabs_dropdown.png19.66 KBesha_kundu
#9 before_tabs_dropdown.png21.16 KBesha_kundu
#5 After Patch Image.png20.32 KBjay jangid
#5 Before Patch Image.png17.65 KBjay jangid
#3 fixed-version.png171.59 KBshweta__sharma
Screenshot at Jul 31 18-24-56.png159.83 KBshweta__sharma

Issue fork creative_innovative-3378208

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

shweta__sharma created an issue. See original summary.

shweta__sharma opened merge request !4

shweta__sharma’s picture

shweta__sharma commented
Status: Active » Needs review
StatusFileSize
new fixed-version.png171.59 KB

Pushed the code, pls review.

jay jangid’s picture

jay jangid commented
Assigned: Unassigned » jay jangid
jay jangid’s picture

jay jangid commented
Assigned: jay jangid » Unassigned
StatusFileSize
new Before Patch Image.png17.65 KB
new After Patch Image.png20.32 KB

Hello @shweta__sharma I verified the MR4 on Drupal 10.1.x and it's working.
Sharing the screenshots for reference.
Only getting this warning on applying it:-

<stdin>:15: trailing whitespace.

warning: 1 line adds whitespace errors.

Thanks.

zeeshan_khan’s picture

zeeshan_khan commented
Status: Needs review » Needs work 
.tabs ul.primary li a {
    border: unset!important;
  }

Can we not use !important as its not a good practice and may have dangerous impact on other components in component base structure.

esha_kundu’s picture

esha_kundu commented
Assigned: Unassigned » esha_kundu

I'll work on this.

esha_kundu opened merge request !22

esha_kundu’s picture

esha_kundu commented
Version: 1.0.x-dev » 9.1.0
Status: Needs work » Needs review
StatusFileSize
new before_tabs_dropdown.png21.16 KB
new after_tabs_dropdown.png19.66 KB
new before_dropdown_button_tabs.mp4235.35 KB
new after_tabs_dropdown_button.mp4247.49 KB

Hello,
I installed the theme version 9.1.0 on Drupal version 10.3.2, the mentioned issue existed so I applied the MR!4 but got patch fail error. Updating the version for this issue. As per the comment by @zeeshan_khan, I have made changes and created MR!22. I also noticed that the dropdown arrow remained facing downward even when the menu list is expanded, according to me this is a design issue that can be solved here as well. I have addressed this and made the arrow face upward whenever the menu list is expanded.
Added ss and short clip for reference. Please review.
Thanks

zeeshan_khan’s picture

zeeshan_khan commented
Status: Needs review » Needs work

@esha_kundu - Thank you for the fixes everythings looks good to me however your merge request has a conflict that needs to be fixed in order to merge the PR.

esha_kundu’s picture

esha_kundu commented
Assigned: esha_kundu » Unassigned
Status: Needs work » Needs review

Hi @zeeshan_khan,
I've resolved the conflicts, please check.
Thanks

kanchan bhogade’s picture

kanchan bhogade commented
Status: Needs review » Needs work
StatusFileSize
new MR22-Error.png64.12 KB

Hi @esha_kundu
I have reproduced the issue on Drupal 10.3.1 with the theme version 9.1.0
But MR 22 is failing
Attaching Screenshot for reference

esha_kundu’s picture

esha_kundu commented
Status: Needs work » Needs review

Hi @Kanchan Bhogade,
As per the screenshot that you have provided I find the MR!22 failed at your end because you have been checking it in 9.1.0 version which is a tag consisting of previous changes. I think if you clone the project and checkout the current development branch 9.1.x, followed by applying the patch then this patch application error would be resolved.
Thanks

esha_kundu changed the visibility of the branch 3391588-readmore-button to hidden.

zeeshan_khan’s picture

zeeshan_khan commented

@esha_kundu - Agreed! - PR is merged!
Thanks

zeeshan_khan’s picture

zeeshan_khan commented
Status: Needs review » Reviewed & tested by the community
zeeshan_khan’s picture

zeeshan_khan commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.