Problem/Motivation

The toolbar currently add a body class "light" or "dark" according to the style.
Such class could impact light/dark mode of custom theming

Proposed resolution

  1. Not inserting any class for the light theme (this will allow also the "Auto" dark mode in the future)
  2. Using modifier class: ".seeds-toolbar--dark "

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork seeds_toolbar-3377986

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

elgandoz created an issue. See original summary.

elgandoz’s picture

elgandoz commented
Title: body class "light" and "dark" may clash with theme » body class "light" and "dark" may clash with themes with dark mode

elgandoz opened merge request !4

elgandoz’s picture

elgandoz commented

The class on the body has been replaced with .seeds_toolbar--light.
This avoids clashing with themes using .light and .dark

elgandoz’s picture

elgandoz commented
Status: Active » Needs review
ahmad-alyasaki’s picture

ahmad-alyasaki commented
Version: 2.0.5 » 2.x-dev

@elgandoz
Hello, thanks for reporting this issue
we fixed the issue based on your recommendation but more edits need to be done on the code we will update the dev version with the new code.

  • ahmad-alyasaki committed 9e2aae3c on 2.x 
    Issue #3377986: body class "light" and "dark" may clash with themes with...
ahmad-alyasaki’s picture

ahmad-alyasaki commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.