Problem/Motivation

  • Refactor the header string of each OpenStack resource in Cloud Dashboard.

Issue fork cloud-3377611

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1907

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Refactor the header string of each OpenStack resource in Cloud Dashboard » Refactor the header format of each OpenStack resource form in SPA (drupal/cloud_dashboard)
Issue summary: View changes

@asai.noriaki

Can you please review the patch? Thanks

asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Needs work

@Ryo Yamashita @yas

Thank you for providing the patch. I tested the patch to work as expected and it mostly worked as expected.
But, please change only the following two points.

(1)The header string for the add screen of OpenStack stack.
- Before change(Now): “Add OpenStack stack - template”
- After change : “Add stack - template”

(2)The header string for the preview screen of OpenStack stack.
- Before change(Now): “Preview OpenStack stack - template”
- After change : “Preview stack - template”

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Refactor the header format of each OpenStack resource form in SPA (drupal/cloud_dashboard) » Refactor the header format in each OpenStack resource form in SPA (drupal/cloud_dashboard)
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Needs work

@Ryo Yamashita @yas

Thank you for providing the patch.
Could you please change the following?

> (2)The header string for the preview screen of OpenStack stack.
> - Before change(Now): “Preview OpenStack stack - template”
> - After change : “Preview stack - template”

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Reviewed & tested by the community

@Ryo Yamashita @yas

Thank you for providing the patch. I tested that it works as expected, And it worked.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@asai.noriaki

Thank you for your review.

@ryo-yamashita

I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 357e004a on 6.x authored by Ryo Yamashita 
    Issue #3377611 by Ryo Yamashita, yas, asai.noriaki: Refactor the header...

  • yas committed 8ba1c313 on 5.x authored by Ryo Yamashita 
    Issue #3377611 by Ryo Yamashita, yas, asai.noriaki: Refactor the header...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.