If you have aliases for every node and you tell to cache/not cache node/#nid , the logic fails currently. Attached patch fixes this and uses drupal_match_path function - inspiration from block module.

CommentFileSizeAuthor
#6 boost-337756.patch1.56 KBmikeytown2
cacheability_settings.patch953 bytesswentel

Comments

mikeytown2’s picture

mikeytown2 commented

Is this still an issue with the latest dev?

patataur’s picture

patataur commented

Isn't it the same issue as http://drupal.org/node/204832 which seems to be solved by the dev version?

mikeytown2’s picture

mikeytown2 commented

This is a different issue, the one that might have fixed it is #174380: Remove symlink creation. Let each path have own file

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Postponed (maintainer needs more info)
mikeytown2’s picture

mikeytown2 commented
Title: Cacheability settings don't work with aliases » Rewrite boost_is_cacheable() to use core API functions.
Category: bug » task
Status: Postponed (maintainer needs more info) » Needs review

This makes the code easier to read & uses core api functions instead of custom code; thus it should go in.

mikeytown2’s picture

mikeytown2 commented
StatusFileSize
new boost-337756.patch1.56 KB

Rerolled patch

mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed

committed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.