Problem/Motivation

below files are not following drupal standred to use Dependency Injection.
src/Form/SettingsForm.php
src/GeoNamesService.php
src/LocationSelectorController.php
src/Plugin/Field/FieldWidget/LocationSelectorWidget.php

Steps to reproduce

during phpcs found below issue.

CommentFileSizeAuthor
#4 dependancy_injection.png61.33 KBrajan kumar
#2 drupal_di.patch11.91 KBshiv_sharma

Comments

Shiv_Sharma created an issue. See original summary.

shiv_sharma’s picture

shiv_sharma commented
Assigned: shiv_sharma » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal_di.patch11.91 KB

Created the patch and module is working as expected.

shiv_sharma’s picture

shiv_sharma commented
Issue summary: View changes
rajan kumar’s picture

rajan kumar commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new dependancy_injection.png61.33 KB

Applied above patch and confirm patch is working fine except a miner whitespace error.
Attaching SS for reference.

dependaency injection

shashank5563’s picture

shashank5563 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.