Problem/Motivation

./vendor/bin/phpcs --standard="Drupal,DrupalPractice" --extensions="php,module,inc,install,test,profile,theme" web/modules/contrib/save_continue/

FILE: /home/shivsharma/project/my-drupal10-site/web/modules/contrib/save_continue/src/Form/SettingsForm.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
  6 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
 15 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/shivsharma/project/my-drupal10-site/web/modules/contrib/save_continue/save_continue.module
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------

Time: 117ms; Memory: 10MB

Steps to reproduce

execute phpcs on module.

Proposed resolution

fix the concern raised bt phpcs.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Shiv_Sharma created an issue. See original summary.

shiv_sharma’s picture

Assigned: shiv_sharma » Unassigned
Status: Active » Needs review
StatusFileSize
new36.36 KB
new1.15 KB

created the patch module is working as expected and also no new warning reported.
after patch screenshot

nishant’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new29.42 KB

Applied above patch and I can confirm patch is working fine.
Attaching SS for reference.

Rajan Kumar made their first commit to this issue’s fork.

rajan kumar’s picture

Status: Reviewed & tested by the community » Fixed

I have reviewed & Merged above patch.

rajan kumar’s picture

Status: Fixed » Closed (fixed)