</code>All core CSS is eventually being migrated to <code>box-sizing: border-box, we should do this here early, because it affects the layout of the elements.

CommentFileSizeAuthor
#4 3377158-box-sizing-global-4.patch1.62 KBabh1shek chauhan
#2 3377158-box-sizing-global-2.patch599 bytesabh1shek chauhan

Issue fork navigation-3377158

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

abh1shek chauhan’s picture

abh1shek chauhan commented
Status: Active » Needs review
StatusFileSize
new 3377158-box-sizing-global-2.patch599 bytes

Adding patch for the global box sizing.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Needs work

This needs to be 1) scoped to the navigation's root element, and 2) also effect ::before and ::after pseudoelements

abh1shek chauhan’s picture

abh1shek chauhan commented
StatusFileSize
new 3377158-box-sizing-global-4.patch1.62 KB

Adding new patch as per above suggestions.

abh1shek chauhan’s picture

abh1shek chauhan commented
Status: Needs work » Needs review

vensires made their first commit to this issue’s fork.

vensires opened merge request !98

vensires’s picture

vensires
Location Greece
commented
Issue summary: View changes

Patch from #4 was created on top of a previous version and didn't apply anymore (eg. no base.css file exists). The MR provides the equivalent for the latest version.

finnsky’s picture

finnsky commented
Status: Needs review » Needs work

Seems rebase needed.

Also maybe to use inherit box-sizing?
https://css-tricks.com/inheriting-box-sizing-probably-slightly-better-be...

vensires’s picture

vensires
Location Greece
commented
Status: Needs work » Needs review

You are right. Changes done.

finnsky’s picture

finnsky commented
Status: Needs review » Reviewed & tested by the community

LGTM!
Thank you!

ckrina made their first commit to this issue’s fork.

  • ckrina committed d69dfe47 on 1.x authored by vensires 
    Issue #3377158 by Abh1shek Chauhan: Need global box-sizing: border-box...
ckrina’s picture

ckrina
she/her
Primary language Catalan
Location Barcelona
commented
Status: Reviewed & tested by the community » Fixed

Thanks all for the fix!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.