Problem/Motivation

  • Add 'action log' and 'console log' feature for the OpenStack instance in SPA.

Issue fork cloud-3377028

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1905

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. I posted my comments. Also, can you please fix the coding standards errors?

https://www.drupal.org/pift-ci-job/2725257

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I pushed the patch for your comments. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamshita

Thank you for the update. I posted my comment. Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the update. Please fix the following coding standard error:

FILE: ...rs/openstack/src/Service/OpenStackOperationsServiceInterface.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 15 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good to me now. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 3647b9e6 on 6.x authored by Ryo Yamashita 
    Issue #3377028 by Ryo Yamashita, yas: Add 'action log' and 'console log...

  • yas committed 5d4f07e3 on 5.x authored by Ryo Yamashita 
    Issue #3377028 by Ryo Yamashita, yas: Add 'action log' and 'console log...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.