Problem/Motivation

See #3087434: [meta] Use FileUrlGenerator::generate() everywhere, then deprecate generateString() and generateAbsoluteString()

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 drupal-3376942-2.patch5.16 KBkingdutch

Issue fork drupal-3376942

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Kingdutch created an issue. See original summary.

kingdutch’s picture

kingdutch
he/him
Primary language English
commented
Assigned: kingdutch » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal-3376942-2.patch5.16 KB

Status: Needs review » Needs work

The last submitted patch, 2: drupal-3376942-2.patch, failed testing. View results

fromme made their first commit to this issue’s fork.

fromme opened merge request !8629

fromme’s picture

fromme commented
Status: Needs work » Needs review

In drupal-3376942-2.patch the method toString() was applied incorrectly. Fixed and opened MR. All tests passed, so i moving issue to review.

smustgrave’s picture

smustgrave commented
Title: Replace usage of generateString with generate in MediaStandardProfileTest » Replace usage of generateString with generate in Media module
Status: Needs review » Needs work

Also looking at #3376945: Replace usage of generateString with generate in MediaDisplayTest and #3376943: Replace usage of generateString with generate in MediaSourceImageTest believe the correct scope would to replace generateString in the "Media" module vs per file. So can the other two be closed out and merged into this one please. Then can mark as seems straightforward

fromme’s picture

fromme commented
Status: Needs work » Needs review

Changes from tasks #3376945: Replace usage of generateString with generate in MediaDisplayTest and #3376943: Replace usage of generateString with generate in MediaSourceImageTest merged into current branch and closed as duplicates.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thanks for taking care of that so quickly! Changes look good

  • catch committed 383f200f on 10.3.x 
    Issue #3376942 by fromme, Kingdutch, smustgrave: Replace usage of...

  • catch committed bcdb2a7c on 10.4.x 
    Issue #3376942 by fromme, Kingdutch, smustgrave: Replace usage of...

  • catch committed e0e68e23 on 11.0.x 
    Issue #3376942 by fromme, Kingdutch, smustgrave: Replace usage of...

  • catch committed 01b55ef5 on 11.x 
    Issue #3376942 by fromme, Kingdutch, smustgrave: Replace usage of...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!

catch closed merge request !8629

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.