Closed (fixed)
Project:
Type Tray
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Jul 2023 at 13:07 UTC
Updated:
9 Aug 2023 at 13:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
minirobot commentedAdding a patch.
Comment #3
minirobot commentedComment #5
marcoscanoLooks good to me, thanks for contributing!
My nitpicky brain has a tendency to complain that there's nothing guaranteeing that at the template level the
{{ category }}variable will be CSS-safe (in theory it could be almost any string), but I believe the idea is that these would be unique, machine-names, and it's fairly safe to assume them as CSS ids, so let's go forward with this.Thanks! 👍
(released https://www.drupal.org/project/type_tray/releases/1.2.3 with this)
Comment #6
penyaskitoI think this is safe, and if it weren't the problem already existed before the patch (see div class).
We can probably use
|clean_classin both for going the safer route.Comment #7
hawkeye.twolf+1 for always using `|clean_class` when printing classes in a template! :D
Comment #8
hawkeye.twolfAlso thank you Betty for the patch and thank you Marcos for such a quick release!!!! :D
Comment #10
marcoscanoSounds good, thanks all!
(and apologies for pulling the trigger too fast! :D )