Problem/Motivation
FILE: /var/www/html/web/modules/onetimeloginlink/src/Form/OneTimeLoginLinkForm.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
14 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
24 | ERROR | [ ] Missing short description in doc comment
41 | ERROR | [x] Expected 1 blank line after function; 3 found
44 | ERROR | [ ] More than 2 empty lines are not allowed
60 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
82 | ERROR | [x] Expected 1 space after IF keyword; 0 found
82 | ERROR | [x] Expected 1 space after closing parenthesis; found 5
Steps to reproduce
./vendor/bin/phpcs --standard="Drupal,DrupalPractice" --extensions="php,module,inc,install,test,profile,theme" web/modules/
Proposed resolution
./vendor/bin/phpcbf --standard="Drupal,DrupalPractice" --extensions="php,module,inc,install,test,profile,theme" web/modules/
After that fix the remaining issue manualy
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | ConvertREADME-3376459-4.patch | 2.96 KB | nishant |
| #2 | Fixtheissuesreportedbyphpcs-3376575-1.patch | 1.37 KB | nishant |
Issue fork onetimeloginlink-3376575
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
nishantAttached Patch for the above issue, Please verify
Comment #3
nishantComment #4
nishantAttached the Latest patch#4,Please review.
Comment #7
rajan kumar commentedI have merged above patch in latest version.
Comment #8
rajan kumar commented