Problem/Motivation

FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/menu_link_clone/tests/src/Functional/MenuLinkCloneTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
 77 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

Steps to reproduce

Please execute this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_link_clone

CommentFileSizeAuthor
#7 phpcs-afterpatch5.png83.18 KBroberttabigue
#5 3376139-5.patch724 bytesnitin_lama

Issue fork menu_link_clone-3376139

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

roberttabigue created an issue. See original summary.

bharath-kondeti made their first commit to this issue’s fork.

bharath-kondeti opened merge request !2

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
Issue summary: View changes
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new 3376139-5.patch724 bytes
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
roberttabigue’s picture

roberttabigue commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new phpcs-afterpatch5.png83.18 KB

Hi,

I reviewed the changes and confirmed the Patch was applied cleanly to the Menu Link Clone module against 8.x-3.2 on Drupal 9.5.10.

Checking patch tests/src/Functional/MenuLinkCloneTest.php...
Applied patch tests/src/Functional/MenuLinkCloneTest.php cleanly.

And all PHPCS errors have been fixed.

I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_link_clone-3376139/

Please see the attached file for reference.

I'm moving this now to RTBC.

Thank you!

vsujeetkumar’s picture

vsujeetkumar commented
Status: Reviewed & tested by the community » Fixed

Thanks everyone to participate and fix this issue.

vsujeetkumar’s picture

vsujeetkumar commented
vsujeetkumar’s picture

vsujeetkumar commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.