Problem/Motivation

The module still refers to older version of ajax_dependency module

Steps to reproduce

Install the module using composer

Proposed resolution

Update composer.json to require latest version of ajax_dependency

CommentFileSizeAuthor
#2 3375844-2.patch267 byteshardikpandya

Issue fork ersv-3375844

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hardikpandya created an issue. See original summary.

hardikpandya’s picture

hardikpandya commented
StatusFileSize
new 3375844-2.patch267 bytes

Here is the patch for this.

hardikpandya’s picture

hardikpandya commented
Assigned: hardikpandya » Unassigned
Status: Active » Needs review
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

LGTM. If you add this as a MR, i can commit is easier.

IT-Cru made their first commit to this issue’s fork.

IT-Cru opened merge request !2

it-cru’s picture

it-cru
Primary language English
Location Munich
commented

@geek-merlin: I've opened MR with patch provided by @hardikpandya

+1 RTBC from me.

it-cru’s picture

it-cru
Primary language English
Location Munich
commented
Status: Needs review » Reviewed & tested by the community
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

  • geek-merlin committed 75870988 on 8.x-1.x authored by IT-Cru 
    Issue #3375844 by hardikpandya, IT-Cru, geek-merlin: Require new stable...
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

Thx for the MR. The d.o merge button seems broken currently, will try next days.

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Reviewed & tested by the community » Fixed

Ah, it worx with the save button. So thx everybody!

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented

Habemus releasem: https://www.drupal.org/project/ersv/releases/8.x-1.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.