Problem/Motivation

Amongst the current suppressions found in the PHPStan level 1 baseline is: Offset 'foo' on array{} in isset() does not exist..

This issue exists to fix all of those.

Steps to reproduce

- Run PHPStan on level 1 and see the above issue amongst all others.

Proposed resolution

- Solve all of the reported issues for the above mentioned.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3374878

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

Spokje opened merge request !4396

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Applied the MR and searched for "message: "#^Offset " and both instances have been replaced. All tests are green so no failures there.

  • lauriii committed 985b1efa on 11.x 
    Issue #3374878 by Spokje: Fix PHPStan L1 errors "Offset 'foo' on array...

  • lauriii committed 11842ed3 on 10.1.x 
    Issue #3374878 by Spokje: Fix PHPStan L1 errors "Offset 'foo' on array...

lauriii closed merge request !4396

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 985b1ef and pushed to 11.x. Thanks! Also cherry-picked to 10.1.x as a test only change.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.