Problem/Motivation

  • You can select the same pull-down as the conventional Horizon for IP protocol options（All ICMP, SSH, HTTPS etc.）
    • Example: TCP port 22 is automatically entered when SSH is selected

Issue fork cloud-3374538

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hosomitm created an issue. See original summary.

hosomitm opened merge request !1890

hosomitm’s picture

hosomitm commented
Status: Active » Needs review

@yas

Please review the code. Thank you.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@hosomitm

Thank you for the patch. I posted my comments. Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@hostomitm

Thank you for the update. The foreach ($items as $item) loop should be foreach ($items ?: [] as $item) style. Thanks

hosomitm’s picture

hosomitm commented
Status: Needs work » Needs review

@yas

I have fixed the issues pointed out in the review.
Please review again. Thanks you.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add a protocol name item to the OpenStack security group IP Protocol dropdown » Add well-known port protocol name items to the IP protocol dropdown list in OpenStack security group form
Status: Needs review » Reviewed & tested by the community

@hostomitm

Thank you for the update. I ran the BDD tests and it worked successfully. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed d75e34bb on 6.x authored by hosomitm 
    Issue #3374538 by hosomitm, yas: Add well-known port protocol name items...

  • yas committed 5c27bdf0 on 5.x authored by hosomitm 
    Issue #3374538 by hosomitm, yas: Add well-known port protocol name items...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.