Incorrect "$format_state" used in call to HMSService::formattedToSeconds [#3374256]

Problem/Motivation

In latest 2.0.x code, there is a call in HMSService::isValid that contains: $this->formattedToSeconds($input, $format, $element, $format_state) !== FALSE
The 4th parameter looks like it should be $form_state per the method docs.

Steps to reproduce

Proposed resolution

Fix the (likely) typo.

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#5	before.png	38.01 KB	kushagra.goyal
#3	hms_field-fix-form-state-parameter-3374256-3.patch	584 bytes	angrytoast

Issue fork hms_field-3374256

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3374256-incorrect-formatstate-used changes, plain diff MR !5
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

12 July 2023 at 23:09

angrytoast created an issue. See original summary.

Comment #2

angrytoast commented 12 July 2023 at 23:10

Issue summary:

View changes

Comment #3

angrytoast commented 12 July 2023 at 23:12

Status	File	Size
new	hms_field-fix-form-state-parameter-3374256-3.patch	584 bytes

Here's a quick patch for the issue.

Comment #4

angrytoast commented 12 July 2023 at 23:13

Status:

Active

» Needs review

Comment #5

kushagra.goyal commented 14 July 2023 at 06:38

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	before.png	38.01 KB

i have reviewed the patch it's working correctly as before it was typo error. and i have checked previously it was giving null but now it is working fine. Hence moving to RTBC..