Since updating to commerce 2.36, my ajax add-to-cart implementation fails with a javascript parse error in the browser console.

Uninstalling this module fixes it.

Commerce 2.36 now includes a checkbox per order type to display the add to cart message, so I guess that's where the problem lies. It does not matter whether that checkbox is checked or not, I still get the parse error with this module enabled.

The ideal situation would be to leave that setting checked, and have this module disable the add to cart message for ajax carts only. It is desirable to display the message for non-ajax carts.

Comments

John Pitcairn created an issue. See original summary.

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Active » Postponed (maintainer needs more info)

Hey thanks for reporting that!

Can you see if the patch in #3366808: TypeError: must be RequestStack, EntityTypeManager given fixes your issue? If it relates to the issue you are referring that should indeed fix the problem.

Otherwise it would also be helpful to post the actual error you get in the js console?

johnpitcairn’s picture

johnpitcairn commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Yup #3366808: TypeError: must be RequestStack, EntityTypeManager given is the problem. Thanks for pushing the new version.