Problem/Motivation
PHPCS reports the following issues:
C:\xampp\htdocs\backendassignment\web\modules\contrib>phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig elevatezoom
FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\elevatezoom\elevatezoom.module
------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
25 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------
FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\elevatezoom\README.md
---------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------
3 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters
38 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
52 | ERROR | [x] Expected 1 newline at end of file; 2 found
---------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------
FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\elevatezoom\src\Plugin\Field\FieldFormatter\ImageElevateZoomFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------
Time: 1.31 secs; Memory: 6MB
Steps to reproduce
Run the phpcs command on the module.
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Comments
Comment #2
sidharth_soman commentedComment #3
clarkssquared commentedHi sidharth_soman,
I applied your patch to my local and I confirmed that your patch fixed all the PHPCS errors/warnings. However, there is a whitespace error when I apply the patch moving this to needs work and remove the extra whitespace to avoid the said error.
Please look at the screenshot attached for your reference.
Thank you
Comment #4
mrinalini9 commentedFixed whitespace issues in patch #2, please review it.
Thanks & Regards,
Mrinalini
Comment #6
keshavv commentedThank you.
Comment #7
keshavv commented