Problem/Motivation

FILE: /var/www/html/vb/d_cont/luxon_formatters/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
30 | WARNING | Line exceeds 80 characters; contains 229 characters
34 | WARNING | Line exceeds 80 characters; contains 229 characters
----------------------------------------------------------------------

Time: 169ms; Memory: 10MB

Steps to reproduce

Execute: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig luxon_formatters/

Remaining tasks

Patch review

CommentFileSizeAuthor
#5 3373823-after-MR1.png32.86 KBclarkssquared
#2 3373823-after-patch.png83.8 KBclarkssquared
coding-standard-fixes.patch1.94 KBurvashi_vora

Issue fork luxon_formatters-3373823

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

urvashi_vora created an issue. See original summary.

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Needs work
StatusFileSize
new 3373823-after-patch.png83.8 KB

Hi urvashi_vora

I applied your patch coding-standard-fixes.patch to my local and I confirmed that your patch fixed the PHPCS issues. However, as I apply your patch I noticed that your patch has a whitespace error so I will move this to needs work and just kindly fix the whitespace error and this will be all good.

Please look at the screenshot I attached for your reference.
Thank you

urvashi_vora’s picture

urvashi_vora commented
Status: Needs work » Needs review

Hi @clarkssquared,

I made the suggested changes, sending a Merge request right ahead.
Please review.

Thanks

urvashi_vora opened merge request !1

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3373823-after-MR1.png32.86 KB

Hi urvashi_vora

I applied your MR !1 to my local and I confirmed that it applies cleanly without errors and fixed all PHPCS issues.

Moving this to RTBC

Thank you

chrisolof’s picture

chrisolof
he/him
Primary language English
commented
Version: 1.0.0-beta3 » 1.0.x-dev
Status: Reviewed & tested by the community » Fixed

Looks great - thank you for your contribution! This has been merged into our 1.0.x branch and will be part of our next release.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.