Problem/Motivation

FILE: .../summary_only/src/Plugin/Field/FieldFormatter/TextSummaryOnlyFormatter.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
85 | WARNING | \Drupal calls should be avoided in classes, use dependency
| | injection instead
--------------------------------------------------------------------------------

Time: 104ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig summary_only/

Remaining tasks

Patch review

CommentFileSizeAuthor
#2 with patch.png240.66 KBkenyoowen
#2 without patch.png173.81 KBkenyoowen
dependency-injection.patch2.18 KBurvashi_vora

Comments

urvashi_vora created an issue. See original summary.

kenyoowen’s picture

kenyoowen commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new without patch.png173.81 KB
new with patch.png240.66 KB

Hi urvashi_vora

I applied your patch and confirmed that it removes the dependency injection issue mentioned above. Please see the screenshots attached.

Thank you.

manishsaharan’s picture

manishsaharan commented
Status: Reviewed & tested by the community » Fixed

Thanks @urvashi_vora for finding and fixing the issue.
The issue is fixed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.