Fix the issues reported by phpcs [#3373757]

Problem/Motivation
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/bootstrap_pages/

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/bootstrap_pages/bootstrap_pages.install
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\NestedArray.
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/VB/drupal-10.1.0/modules/contrib/bootstrap_pages/CONTRIBUTOR.md
-----------------------------------------------------------------------------------
FOUND 1 ERROR AND 24 WARNINGS AFFECTING 25 LINES
-----------------------------------------------------------------------------------
30 | WARNING | [ ] Line exceeds 80 characters; contains 113 characters
35 | WARNING | [ ] Line exceeds 80 characters; contains 135 characters
36 | WARNING | [ ] Line exceeds 80 characters; contains 90 characters
48 | WARNING | [ ] Line exceeds 80 characters; contains 236 characters
52 | WARNING | [ ] Line exceeds 80 characters; contains 192 characters
60 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
63 | WARNING | [ ] Line exceeds 80 characters; contains 427 characters
65 | WARNING | [ ] Line exceeds 80 characters; contains 128 characters
70 | WARNING | [ ] Line exceeds 80 characters; contains 171 characters
74 | WARNING | [ ] Line exceeds 80 characters; contains 115 characters
76 | WARNING | [ ] Line exceeds 80 characters; contains 151 characters
77 | WARNING | [ ] Line exceeds 80 characters; contains 448 characters
83 | WARNING | [ ] Line exceeds 80 characters; contains 99 characters
87 | WARNING | [ ] Line exceeds 80 characters; contains 294 characters
100 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
101 | WARNING | [ ] Line exceeds 80 characters; contains 101 characters
102 | WARNING | [ ] Line exceeds 80 characters; contains 142 characters
103 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters
105 | WARNING | [ ] Line exceeds 80 characters; contains 137 characters
106 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
112 | WARNING | [ ] Line exceeds 80 characters; contains 91 characters
114 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
131 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
135 | WARNING | [ ] Line exceeds 80 characters; contains 234 characters
150 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------

Time: 479ms; Memory: 10MB

Steps to reproduce
Run this command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/bootstrap_pages/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comment	File	Size	Author
#7	phpcs-afterlatestMR.png	152.7 KB	roberttabigue

Issue fork bootstrap_pages-3373757

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3373757-fix-the-issues changes, plain diff MR !2
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

11 July 2023 at 03:04

Indrapatil created an issue. See original summary.

Comment #2

11 July 2023 at 06:16

Indrapatil opened merge request !2

Comment #3

indrapatil commented 11 July 2023 at 06:16

Assigned:	indrapatil	» Unassigned
Status:	Active	» Needs review

Comment #4

roberttabigue commented 21 July 2023 at 14:25

Status:

Needs review

» Needs work

Hi @Indrapatil,

After applying the latest MR !2 to the Bootstrap Pages module against 8.x-1.x-dev on Drupal 9.5.10, I'm still seeing several errors:

FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/bootstrap_pages/CONTRIBUTOR.md
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 24 WARNINGS AFFECTING 24 LINES
----------------------------------------------------------------------------------------------------------
  30 | WARNING | Line exceeds 80 characters; contains 113 characters
  35 | WARNING | Line exceeds 80 characters; contains 135 characters
  36 | WARNING | Line exceeds 80 characters; contains 90 characters
  48 | WARNING | Line exceeds 80 characters; contains 236 characters
  52 | WARNING | Line exceeds 80 characters; contains 192 characters
  60 | WARNING | Line exceeds 80 characters; contains 93 characters
  63 | WARNING | Line exceeds 80 characters; contains 427 characters
  65 | WARNING | Line exceeds 80 characters; contains 128 characters
  70 | WARNING | Line exceeds 80 characters; contains 171 characters
  74 | WARNING | Line exceeds 80 characters; contains 115 characters
  76 | WARNING | Line exceeds 80 characters; contains 151 characters
  77 | WARNING | Line exceeds 80 characters; contains 448 characters
  83 | WARNING | Line exceeds 80 characters; contains 99 characters
  87 | WARNING | Line exceeds 80 characters; contains 294 characters
 100 | WARNING | Line exceeds 80 characters; contains 81 characters
 101 | WARNING | Line exceeds 80 characters; contains 101 characters
 102 | WARNING | Line exceeds 80 characters; contains 142 characters
 103 | WARNING | Line exceeds 80 characters; contains 103 characters
 105 | WARNING | Line exceeds 80 characters; contains 137 characters
 106 | WARNING | Line exceeds 80 characters; contains 81 characters
 112 | WARNING | Line exceeds 80 characters; contains 91 characters
 114 | WARNING | Line exceeds 80 characters; contains 100 characters
 131 | WARNING | Line exceeds 80 characters; contains 82 characters
 135 | WARNING | Line exceeds 80 characters; contains 234 characters
----------------------------------------------------------------------------------------------------------

Time: 500ms; Memory: 10MB

I'm moving this for now to Needs work for investigations.
Thank you!

Comment #5

imustakim commented 26 July 2023 at 15:09

Assigned:

Unassigned

» imustakim

Comment #6

imustakim commented 26 July 2023 at 15:29

Assigned:	imustakim	» Unassigned
Status:	Needs work	» Needs review

MR updated and now only these two issues are remaining because these lines contains link and we can't break it.
Assuming these can be ignored.
Rest of the errors are fixed.
Please review.

FILE: /Users/specbee/Sites/Projects/bootstrap_pages-3373757/CONTRIBUTOR.md
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
  38 | WARNING | Line exceeds 80 characters; contains 84 characters
 152 | WARNING | Line exceeds 80 characters; contains 81 characters
--------------------------------------------------------------------------

Time: 417ms; Memory: 10MB

Comment #7

roberttabigue commented 26 July 2023 at 17:00

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	phpcs-afterlatestMR.png	152.7 KB

Hi,

I applied the latest MR and confirmed I'm seeing the 2 issues remaining mentioned above which can be ignored.

I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig bootstrap_pages/

Please see the attached file for reference.

I'm moving this now to RTBC.

Thank you!

Comment #8

29 April 2024 at 23:58

thejimbirch made their first commit to this issue’s fork.

Comment #9

thejimbirch commented 30 April 2024 at 00:01

Status:

Reviewed & tested by the community

» Fixed

Merged, thanks!

Comment #10

14 May 2024 at 00:04

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Fix the issues reported by phpcs

Problem/Motivation
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/bootstrap_pages/

Steps to reproduce
Run this command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/bootstrap_pages/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork bootstrap_pages-3373757

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

News items

Our community

Documentation

Drupal code base

Governance of community

Fix the issues reported by phpcs

Problem/Motivation phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/bootstrap_pages/

Steps to reproduce Run this command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/bootstrap_pages/

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork bootstrap_pages-3373757

Comments

Problem/Motivation
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/bootstrap_pages/

Steps to reproduce
Run this command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/bootstrap_pages/