Fix the issues reported by phpcs [#3373142]

GitLab CI reports a PHP_CodeSniffer error which should be fixed.

FILE: ...r-3373142/src/Plugin/WebformHandler/SubmissionSimplenewsWebformHandler.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 9 | ERROR | [x] Use statements should be sorted alphabetically. The first
   |       |     wrong one is Drupal\webform\Utility\WebformOptionsHelper.
   |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 203ms; Memory: 6MB

Issue fork webform_simplenews_handler-3373142

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3373142-fix-the-issues changes, plain diff MR !3
Check out this branch for the first time

Check out existing branch, if you already have it locally
3373142-fix-phpcs-errors/warnings compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

1 hidden branch

3373142-gitlab-ci-reports

changes, plain diff MR !9

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

7 July 2023 at 10:10

Indrapatil created an issue. See original summary.

Comment #2

7 July 2023 at 10:14

Indrapatil opened merge request !3

Comment #3

indrapatil commented 7 July 2023 at 10:15

Assigned:	indrapatil	» Unassigned
Status:	Active	» Needs review

Comment #4

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 7 July 2023 at 11:49

Issue summary:

View changes

Comment #5

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 7 July 2023 at 11:53

Priority:

Normal

» Minor

Comment #6

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 7 July 2023 at 11:54

Status:

Needs review

» Needs work

Comment #7

9 July 2023 at 18:54

bharath-kondeti made their first commit to this issue’s fork.

Comment #8

viren18febs commented 28 September 2023 at 05:26

Status:

Needs work

» Needs review

Comment #9

rudrakumar188 commented 13 October 2023 at 03:00

By Running

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig /var/www/html/VB/drupal-10.1.0/modules/contrib/webform_simplenews_handler-2.0.1

was able to reproduce error in D10.1 and MR request fixes the error.

Comment #10

a.aaronjake commented 15 August 2024 at 08:00

Hi @bharath_kondeti,

Applied the changes you committed on MR!3, it was applied not-so successfully, but miraculously, there are no errors reported.

➜  webform_simplenews_handler git:(2.0.x) curl https://git.drupalcode.org/project/webform_simplenews_handler/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1805    0  1805    0     0   4388      0 --:--:-- --:--:-- --:--:--  4467
patching file README.md
patching file src/Plugin/WebformHandler/SubmissionSimplenewsWebformHandler.php
patching file webform_simplenews_handler.info.yml
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file webform_simplenews_handler.info.yml.rej
➜  webform_simplenews_handler git:(2.0.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig webform_simplenews_handler
➜  contrib git:(master) ✗

Will not transition this yet so that others will review it too.

Thanks,
Jake