Problem/Motivation

Upgrade status report: Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

on:

scanner/src/AdminHelper.php:89

Steps to reproduce

Scan with Upgrade Status module.

Proposed resolution

Add explicit access check.

Remaining tasks

Provide issue fork/patch.

CommentFileSizeAuthor
#3 3372857_scanner_fix-access-check-3.diff475 bytescodebymikey

Issue fork scanner-3372857

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

codebymikey created an issue. See original summary.

codebymikey opened merge request !23

codebymikey’s picture

codebymikey commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 3372857_scanner_fix-access-check-3.diff475 bytes
aaron.ferris’s picture

aaron.ferris commented

LGTM, patch applies cleanly.

aaron.ferris’s picture

aaron.ferris commented
Status: Needs review » Reviewed & tested by the community
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Confirming RTBC. accessCheck has been added in all other places in the past, but this seems to have been forgotten.

@aaron.ferris saw you in many issues here, wouldn't you perhaps like to apply as Co-Maintainer?

smustgrave closed merge request !23

  • smustgrave committed c755e961 on 8.x-1.x 
    Issue #3372857 by codebymikey, aaron.ferris, anybody: Fix access check...
smustgrave’s picture

smustgrave commented
Status: Reviewed & tested by the community » Fixed

Just joined the scanner team! Going to commit this for a stable release for 8.x-1.x then will plan for D11 :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Whao this is great news @smustgrave Thank you!!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.