Problem/Motivation

FILE: /var/www/html/vb/d_cont/forcedfiledeletion/forcedfiledeletion.module
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
38 | ERROR | [x] There must be exactly one blank line before the tags in a doc
| | comment
38 | ERROR | [ ] Missing parameter type
41 | ERROR | [ ] If there is no return value for a function, there must not be
| | a @return tag.
41 | ERROR | [ ] Description for the @return value is missing
45 | ERROR | [x] PHP keywords must be lowercase; expected "instanceof" but
| | found "instanceOf"
63 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/forcedfiledeletion/forcedfiledeletion.info.yml
----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------

Time: 103ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig forcedfiledeletion/

Remaining tasks

Patch review

CommentFileSizeAuthor
#6 afterthepatch.png73.22 KBroberttabigue
#5 3371952-5.patch1.25 KBsoham sengupta
#4 afterthepatch.png129.81 KBroberttabigue
#4 beforethepatch.png236.98 KBroberttabigue
#3 fixed.patch1.19 KBanjali mehta
#2 patcherror.png153.55 KBroberttabigue
coding-standard-fixes.patch1.67 KBurvashi_vora

Comments

urvashi_vora created an issue. See original summary.

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Needs work
StatusFileSize
new patcherror.png153.55 KB

Hi @urvashi_vora,

I got an error when applying your Patch, please see the attached screenshot for reference.

Moving this to Needs work.

Thank you.

anjali mehta’s picture

anjali mehta commented
Status: Needs work » Needs review
StatusFileSize
new fixed.patch1.19 KB

Created a patch to fix the issues reported by phpcs.

Please review.
Thank You.

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Needs work
StatusFileSize
new beforethepatch.png236.98 KB
new afterthepatch.png129.81 KB

Hi @anjali,

I reviewed your changes and confirmed the Patch was applied cleanly.

Checking patch forcedfiledeletion.info.yml...
Checking patch forcedfiledeletion.module...
Applied patch forcedfiledeletion.info.yml cleanly.
Applied patch forcedfiledeletion.module cleanly.

However, I'm still seeing PHPCS errors, please see the attached file "afterthepatch.png".

Moving this to Needs work, kindly check, please.

Thank you!

soham sengupta’s picture

soham sengupta commented
Status: Needs work » Needs review
StatusFileSize
new 3371952-5.patch1.25 KB

Hi,
I have updated the patch file with the remaining fixes.

roberttabigue’s picture

roberttabigue commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new afterthepatch.png73.22 KB

Hi @soham,

I reviewed your latest changes and confirmed the Patch was applied cleanly.

Checking patch forcedfiledeletion.info.yml...
Checking patch forcedfiledeletion.module...
Applied patch forcedfiledeletion.info.yml cleanly.
Applied patch forcedfiledeletion.module cleanly.

And all PHPCS errors have been fixed.

I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig forcedfiledeletion/

Successfully applied to Forced File Deletion module with 1.0.x-dev version and with the Drupal core version of 9.5.x.

Please see the attached file for your reference.

I'm moving this now to RTBC.

Thank you!