Drupal9 is almost end of life, we need to support Drupal 10

The required access checks are added to entity queries.

The version in the info file is changed to Drupal 9 / 10

CommentFileSizeAuthor
#2 3371620-call-to-a-member-function-getPreferredLangcode.patch3.32 KBjorisclaes

Issue fork commerce_stock_notifications-3371620

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jorisclaes created an issue. See original summary.

jorisclaes’s picture

jorisclaes commented
StatusFileSize
new 3371620-call-to-a-member-function-getPreferredLangcode.patch3.32 KB

While testing the Drupal 10 fork, I ran into an additional issue

Error: Call to a member function getPreferredLangcode() on bool in Drupal\commerce_stock_notifications\Plugin\QueueWorker\CommerceStockNotifyQueue->processItem() (line 114 of modules/contrib/commerce_stock_notifications/src/Plugin/QueueWorker/CommerceStockNotifyQueue.php).

I added a separate patch for this

jorisclaes opened merge request !11

jorisclaes opened merge request !12

agoradesign’s picture

agoradesign commented
Priority: Major » Critical

changed priority to critical, now that Drupal 9 is reaching EOL next month. there's not too much to do here.

I know, we all spend our spare times for maintaining our Drupal modules, but please take these few minutes and make this module D10 compatible

jcmartinez made their first commit to this issue’s fork.

jcmartinez opened merge request !14

jcmartinez’s picture

jcmartinez
Location Raleigh, NC, USA
commented

Code maintainers.

The MR14 adds patch #2 contributed by jorisclaes.

If you can accept the MR11 and then the MR14, we should have a version of this module compatible with D10.

Thanks!

poker10 closed merge request !12

poker10’s picture

poker10 commented
Status: Active » Needs work

Thanks for working on this. I think we should focus on MR 11 here.

MR 14 will be solved in #3215770: anonymous cannot create notifications although /permissions allow it?, so let's not mix this up.

Added a few comments to the MR, otherwise I think this looks good.

Once we fix all outstanding issues, I will roll out a new D10 compatible release (alpha or beta).

chrisscrumping’s picture

chrisscrumping commented

Would be good get this merged, I am happy to help by applying the suggested changes if that's all that's required?

poker10’s picture

poker10 commented

@ChrisScrumping yes, it would be great if you can update the MR and prepare it for review. I can take a look then a finish it / commit.

I would say we can keep old core versions and old php versions in case it does not do any harm (maybe it will be less disrupting for sites).

Thanks!

chrisscrumping’s picture

chrisscrumping commented

Should be okay now hopefully?

poker10’s picture

poker10 commented
Status: Needs work » Fixed

Committed and pushed. Thanks all!

chrisscrumping’s picture

chrisscrumping commented

Thanks poker10 great stuff!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.