This theme uses a README.txt file as documentation file. Since drupal.org migrated to Gitlab, which renders a Markdown file as HTML, that file should be replaced by a README.md file that uses the template defined in README.md template.

Bear in mind that the Markdown coding standards, part of the Drupal coding standards, are still being discussed. Eventually, the content of the README.md file will need to be changed.

CommentFileSizeAuthor
#15 README.MD.png100.39 KBBushra Shaikh
#9 readme_3.png161.05 KBtanuja bohra
#9 readme_2.png135.15 KBtanuja bohra
#9 readme_1.png154.99 KBtanuja bohra
#6 README.md.patch1.19 KBsonam_sharma
#3 3370593 - patch apply.png136.55 KBkenyoowen
#3 3370593 - README txt.png157.66 KBkenyoowen
#3 3370593 - download theme.png258.48 KBkenyoowen
README.md1.28 KBsonam_sharma

Issue fork fashion_beauty-3370593

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sonam_sharma created an issue. See original summary.

sonam_sharma’s picture

sonam_sharma commented

hello,
I have added README.md file
please! check it

kenyoowen’s picture

kenyoowen commented
Assigned: sonam_sharma » Unassigned
Status: Needs review » Needs work
StatusFileSize
new 3370593 - download theme.png258.48 KB
new 3370593 - README txt.png157.66 KB
new 3370593 - patch apply.png136.55 KB

Hi sonam_sharma

I reviewed your patch and it is not following the README.md template and your patch doesn't apply. README.txt should be removed and replaced with README.md hence it will be redundant. Please see the screenshots attached.

Thank you.

sonam_sharma opened merge request !8

sonam_sharma’s picture

sonam_sharma commented
sonam_sharma’s picture

sonam_sharma commented
StatusFileSize
new README.md.patch1.19 KB

Anjali Mehta made their first commit to this issue’s fork.

anjali mehta’s picture

anjali mehta commented
Status: Needs work » Needs review

Hello Everyone
Updated the file. Please review the changes.
Thank You.

tanuja bohra’s picture

tanuja bohra commented
StatusFileSize
new readme_1.png154.99 KB
new readme_2.png135.15 KB
new readme_3.png161.05 KB

@Anjali Mehta, Verified the MR8 and the readme.md is updated as per standard. Added the screenshots for reference.

The only issue I can see the patch is not cleanly applied ->
8.patch:72: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

Please have a look.

thakurnishant_06 made their first commit to this issue’s fork.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Category: Bug report » Task
Status: Needs review » Needs work
Issue tags: +Needs issue summary update

The issue summary should always describe what should be fixed/changed, even in the case the issue is blatantly obvious. Neither the title nor screenshots are sufficient to describe what the issue is, even in the case a patch is provided.

nitin_lama made their first commit to this issue’s fork.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented

Updated README.md file as per README.md template.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: missing Readme.md file » Replace the README.txt file with the README.md file
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: -Needs issue summary update
Bushra Shaikh’s picture

Bushra Shaikh commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new README.MD.png100.39 KB

Verified the MR !8 and the readme.md is updated as per standard. Added the screenshots for reference.

Can be move to RTBC +1

arti_parmar made their first commit to this issue’s fork.

arti_parmar’s picture

arti_parmar commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.