Problem/Motivation

PublicConstantVisibilityRector

Proposed resolution

Explicitly declare constant visibility.

Issue fork orange_dam-3370339

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

markdorison created an issue. See original summary.

markdorison opened merge request !9

markdorison’s picture

markdorison
he/him
commented
Status: Active » Needs review

adamzimmermann made their first commit to this issue’s fork.

adamzimmermann’s picture

adamzimmermann commented
Status: Needs review » Fixed

Merged. Thank you for the improvements.

For this issue and another one I have had to merge the MR from GitLab. The merge button at the bottom of the issue page (this page) would fail. I'm not sure what is going on. Mark, is this related to any of the pipelines you have configured?

markdorison’s picture

markdorison
he/him
commented

@adamzimmermann Did this occur after you had already merged a different MR. Maybe you needed to rebase this one first in the GitLab UI?

AFAIK pipelines should not be related.

adamzimmermann’s picture

adamzimmermann commented

@markdorison ah that might be it. I rebased a different issue branch and was able to use the button, so that checks out. Thanks for explaining that.

markdorison opened merge request !10

markdorison’s picture

markdorison
he/him
commented
Status: Fixed » Needs review

adamzimmermann’s picture

adamzimmermann commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.