Problem/Motivation

Adding both core and core_version_requirement with anything other than core_version_requirement: ^8 || ^9 will result in an exception. This is not valid because the core: key would include versions that do not recognize the core_version_requirement: key.

Steps to reproduce

For example, a theme that is compatible with Drupal 8 versions after Drupal 8.8.0 and also Drupal 9 will need an info.yml file like this:

name: My Module
type: module
core_version_requirement: ^8 || ^9 || ^10

CommentFileSizeAuthor
#5 after-patch.jpg32.15 KBpriya_degwekar
#4 patch.jpg13.73 KBpriya_degwekar
#2 remove-core-key-3370025-2.patch390 bytesharshita mehna

Comments

Harshita mehna created an issue. See original summary.

harshita mehna’s picture

harshita mehna commented
Status: Active » Needs review
StatusFileSize
new remove-core-key-3370025-2.patch390 bytes

Hello Maintainers,
I have provided a patch to fix this issue.
To get more information visit https://www.drupal.org/node/3070687
Please review it.

Thanks!

akshay kashyap’s picture

akshay kashyap commented
Status: Needs review » Reviewed & tested by the community

@Harshita mehna

Thanks for the Work.

I have reviewed and tested the #2 patch it looks good. Removing core: 8.x and adding core_version_requirement: ^8 || ^9 || ^10 into infol.yml file. The module is compatible is Drupal 8,9,10.

Moving to RTBC

priya_degwekar’s picture

priya_degwekar commented
StatusFileSize
new patch.jpg13.73 KB

Hi All, Patch looks fine.
Adding screenshots.
Thanks :)

priya_degwekar’s picture

priya_degwekar commented
StatusFileSize
new after-patch.jpg32.15 KB
keshavv’s picture

keshavv commented
Status: Reviewed & tested by the community » Fixed
keshavv’s picture

keshavv commented
Status: Fixed » Closed (fixed)