Closed (fixed)
Project:
Multi region
Version:
1.0.0-alpha1
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Jun 2023 at 07:26 UTC
Updated:
12 Mar 2026 at 13:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sonam_sharma commentedComment #3
avpadernoSince the issue is showing what PHP_CodeSniffer shows, let us rescope it to fix all the warnings/errors reported by PHP_CodeSniffer.
The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.
Comment #4
immaculatexavier commentedUpdated issue summary.
Comment #5
immaculatexavier commentedUpdated issue summary.
Comment #6
immaculatexavier commentedUpdated issue summary.
Comment #7
immaculatexavier commentedThis summary provides a clear overview of the issue, the affected files, steps to reproduce, and the proposed resolution. Hope this helps !!!
Comment #10
kalash-j commentedhello , i have solved all the issues that PHPCS has shown.
MR!2 have 0 PHPCS error please check.
Comment #11
clarkssquared commentedHi
I applied the updated MR !2 and I followed the steps to reproduce and confirmed that the PHPCS issues are now resolved:
Comment #12
avpadernoComment #13
avpadernoComment #14
kalash-j commented@apaderno i have done the changes on the feedback you have provided
Comment #15
tirupati_singh commentedHi, I've applied the MR!2 as patch and it applied successfully with no errors. After applying patch all the mentioned phpcs errors has been resolved successfully. Hence, moving the issue status to Reviewed and tested.
Comment #18
avpadernoComment #21
avpadernoComment #23
avpadernoComment #24
avpadernoThe merge request fixes all the PHP_CodeSniffer errors/warnings reported by GitLab CI.
Comment #25
roberttabigue commentedHi,
I reviewed the PHPCS in the GitLab CI pipeline and confirmed that the errors are no longer exist.
Here is the link for reference:
PHPCS: https://git.drupalcode.org/issue/multi_region-3370016/-/jobs/8377040
I'm moving this now to "RTBC".
Thank you!
Comment #28
isaacrc commentedFixed and merged into the 2.0.0 release. Thanks, everyone!
Comment #30
isaacrc commented