Problem/Motivation

file.module calls:

// Load all Field module hooks for File.
require_once __DIR__ . '/file.field.inc'; 

However, file.field.inc only contains two template preprocess functions (template_preprocess_file_widget_multiple() and template_preprocess_file_upload_help()) and an 'internal' function file_field_find_file_reference_column that is only used by file_get_file_references in file.module.

Steps to reproduce

Proposed resolution

Move functions from file.field.inc to file.module and deprecate according to https://www.drupal.org/about/core/policies/core-change-policies/drupal-d...

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3368880

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

kim.pepper created an issue. See original summary.

kim.pepper’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Deprecation appears to be good.

longwave’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs change record

Needs a change record and the deprecation link updating to point to it, otherwise this looks ready to go.

kim.pepper’s picture

Status: Needs work » Reviewed & tested by the community

Re-based on 11.x, added change record and updated deprecation link. Back to RTBC

spokje’s picture

Issue tags: -Needs change record

  • catch committed 5067812f on 11.x
    Issue #3368880 by kim.pepper, longwave: Deprecate file.field.inc and...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed 5067812 and pushed to 11.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

quietone’s picture

Publish change record