Maybe I am mistaken but I didn't managed to get the module working without the code from the module page.

Issue fork ckeditor_svg_icon-3368023

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Harlor created an issue. See original summary.

Harlor opened merge request !2

harlor’s picture

harlor commented
Status: Active » Needs review
aaronchristian’s picture

aaronchristian commented

@Harlor, Thanks for your contribution.

Are you able to attach some screenshots? I'm test the MR but still can't get things to load in the shadow DOM properly.

Thanks!

aaronchristian’s picture

aaronchristian commented
Status: Needs review » Needs work

  • aaronchristian committed 9bdfc3f1 on main 
    Issue #3368023: Add a filter that resolves icon references to the sprite...

  • aaronchristian committed 54b30d5f on main 
    Issue #3368023: Pass the sprite URL and sizes to the editor and declare...
aaronchristian’s picture

aaronchristian commented
Status: Needs work » Fixed

Fixed by a full rebuild in #3624166, which supersedes MR !2's approach — the sprite is now loaded by fetching its URL directly (<use href="{spriteUrl}#name">) rather than inlining it, so no page_bottom hook is needed. Thanks for the MR, Harlor, it pointed at the right file.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.