Problem/Motivation

json_encode expect a non-empty string as the first parameter. We should verify that all text passed to json_encode is valid json.

Example error in ResponsiveImageStylesTwigExtension line 79:

JsonException: Syntax error in json_decode() (line 79 of modules/contrib/pagedesigner_responsive_images/src/ResponsiveImageStylesTwigExtension.php).
Drupal\pagedesigner_responsive_images\ResponsiveImageStylesTwigExtension->getImageStyles() (Line: 70)
__TwigTemplate_8f74970056ce4280fe6531e6c8ed6283->doDisplay() (Line: 405)
Twig\Template->displayWithErrorHandling() (Line: 378)
Twig\Template->display() (Line: 85)
__TwigTemplate_2419b483df3b943f628de4d90fe6130d->doDisplay() (Line: 405)
Twig\Template->displayWithErrorHandling() (Line: 378)
Twig\Template->display() (Line: 390)
Twig\Template->render() (Line: 55)
twig_render_template() (Line: 384)
Drupal\Core\Theme\ThemeManager->render() (Line: 433)
Drupal\Core\Render\Renderer->doRender() (Line: 446)
Drupal\Core\Render\Renderer->doRender() (Line: 204)
Drupal\Core\Render\Renderer->render() (Line: 479)
Drupal\Core\Template\TwigExtension->escapeFilter() (Line: 42)
__TwigTemplate_6a5f95dc5741cf54f5725ce069088987->doDisplay() (Line: 405)
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pvbergen created an issue. See original summary.

pvbergen’s picture

Status: Active » Needs review
pvbergen’s picture

Status: Needs review » Fixed

  • pvbergen committed b29df234 on 2.2.x
    Issue #3367893: JsonException when sizes['#text'] is empty
    

  • pvbergen committed b29df234 on 2.x
    Issue #3367893: JsonException when sizes['#text'] is empty
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.