Problem/Motivation

t() calls should be avoided.

Steps to reproduce

t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead.

CommentFileSizeAuthor
#7 t_calls_should_be_avoided_3367607-6.patch35.96 KBkeshavv
#5 interdiff-2-5.txt1.4 KBnitin_lama
#5 string-translation-trait-3367607-5.patch30.56 KBnitin_lama
#3 3367607 - after.png388.31 KBkenyoowen
#3 3367607 - before.png348.41 KBkenyoowen
#2 string-translation-trait-3367607-2.patch29.07 KBharshita mehna

Comments

Harshita mehna created an issue. See original summary.

harshita mehna’s picture

harshita mehna commented
Status: Active » Needs review
StatusFileSize
new string-translation-trait-3367607-2.patch29.07 KB

I have uploaded a patch to fix this issue.
Please review it.
Thank you!

kenyoowen’s picture

kenyoowen commented
Status: Needs review » Needs work
StatusFileSize
new 3367607 - before.png348.41 KB
new 3367607 - after.png388.31 KB

Hi Harshita mehna

I applied your patch and it removes some of the issues mentioned, but there is still t() calls should be avoided issues which can be found in file: uber_affiliate/src/Plugin/Block/UberAffiliateBlock.php. Please see the screenshots attached.

Thank you.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: Unassigned » nitin_lama
nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Status: Needs work » Needs review
StatusFileSize
new string-translation-trait-3367607-5.patch30.56 KB
new interdiff-2-5.txt1.4 KB

Addressed #3. Please review. Thanks.

nitin_lama’s picture

nitin_lama
he/him
Location India
commented
Assigned: nitin_lama » Unassigned
keshavv’s picture

keshavv commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new t_calls_should_be_avoided_3367607-6.patch35.96 KB

Patch #5 failed to apply. So I have created a new one.

  • keshav.k authored 9b084209 on 2.0.x 
    Issue #3367607 by nitin_lama, keshav.k: t() calls should be avoided
keshavv’s picture

keshavv commented
Version: 1.0.x-dev » 2.0.x-dev
keshavv’s picture

keshavv commented
keshavv’s picture

keshavv commented
Status: Reviewed & tested by the community » Fixed
keshavv’s picture

keshavv commented
Status: Fixed » Closed (fixed)