Problem/Motivation

FILE: /var/www/html/vb/d_cont/graphql_search_api_solr/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 84 characters
43 | WARNING | Line exceeds 80 characters; contains 84 characters
----------------------------------------------------------------------

FILE: ...ar/www/html/vb/d_cont/graphql_search_api_solr/src/Query/SearchApiQuery.php
--------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
--------------------------------------------------------------------------------
27 | ERROR | Missing @var tag in member variable comment
32 | ERROR | Missing @var tag in member variable comment
37 | ERROR | Missing @var tag in member variable comment
42 | ERROR | Missing @var tag in member variable comment
47 | ERROR | Missing @var tag in member variable comment
52 | ERROR | Missing @var tag in member variable comment
57 | ERROR | Missing @var tag in member variable comment
--------------------------------------------------------------------------------

FILE: .../d_cont/graphql_search_api_solr/src/Plugin/GraphQL/Wrappers/FacetsList.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
14 | ERROR | Missing @var tag in member variable comment
19 | ERROR | Missing @var tag in member variable comment
--------------------------------------------------------------------------------

FILE: .../d_cont/graphql_search_api_solr/src/Plugin/GraphQL/Wrappers/FacetValue.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
12 | ERROR | Missing @var tag in member variable comment
17 | ERROR | Missing @var tag in member variable comment
22 | ERROR | Missing @var tag in member variable comment
--------------------------------------------------------------------------------

FILE: ..._cont/graphql_search_api_solr/src/Plugin/GraphQL/Wrappers/SolrDocument.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------
14 | ERROR | Missing @var tag in member variable comment
19 | ERROR | Missing @var tag in member variable comment
47 | WARNING | Unused variable $resultFields.
--------------------------------------------------------------------------------

FILE: ...l_search_api_solr/src/Plugin/GraphQL/DataProducer/SearchApi/SolrSearch.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
89 | ERROR | Type hint "\Drupal\search_api\ParseMode\ParseModePluginManager"
| | missing for $parseModeManager
89 | ERROR | Type hint "\Drupal\Core\Logger\LoggerChannel" missing for
| | $logger
89 | ERROR | Type hint "\Drupal\Core\Pager\PagerManager" missing for
| | $pagerManager
132 | ERROR | Type hint "array" missing for $facets
172 | ERROR | Type hint "array" missing for $facets
172 | ERROR | Type hint "array" missing for $fieldNames
--------------------------------------------------------------------------------

Time: 226ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig graphql_search_api_solr/

Proposed resolution

Fix the issues reported for Drupal and DrupalPractice coding standards.

Remaining tasks

Patch review

CommentFileSizeAuthor
#2 3366399-testing-result.png153.09 KBclarkssquared
coding-standard-fixed.patch4.93 KBurvashi_vora

Issue fork graphql_search_api_solr-3366399

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

urvashi_vora created an issue. See original summary.

clarkssquared’s picture

clarkssquared commented
StatusFileSize
new 3366399-testing-result.png153.09 KB

Hi urvashi_vora

I tested the PHPCS for GraphQL Search API Solr v1.0.x-dev to my local with Drupal 9.5.9 and I noticed that the PHPCS errors are few on my end compared to the errors you reported, however, I applied your coding-standard-fixed.patch and it fixed the PHPCS errors of the module in my end, retaining this to needs review for someone to review and replicate the same errors you reported for the patch's effectivity.

Please look at the screenshot attached for your reference

b2f’s picture

b2f commented
Status: Needs review » Reviewed & tested by the community

Could you please add a fork on gitlab ?

smavri made their first commit to this issue’s fork.

smavri opened merge request !6

  • smavri committed 24c11cf8 on 1.0.x 
    Fix errors reported by phpcs #3366399
smavri’s picture

smavri commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

smavri’s picture

smavri commented
Status: Fixed » Closed (fixed)