Problem/Motivation

  • Fix the error, and after the key pair is registered, the message should display correctly and the private key can be downloaded.

Issue fork cloud-3366345

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1833

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Category: Task » Bug report
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Needs work

@Ryo Yamashita @yas

Thank you for providing the patch. I tested that it works as expected. But it didn't work as expected.
I think the private key download URL path is probably wrong.

Currently, the URL path is as follows.
- /clouds/aws_cloud/${cloudContext}/key_pair/${id}/download

However, isn't the actual URL path correct as follows?
- /clouds/openstack/${cloudContext}/key_pair/${id}/download

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@asai.noriaki @yas

I think the private key download URL path is probably wrong.

I pushed a commit for fixing this problem. Thanks.

asai.noriaki’s picture

asai.noriaki commented
Status: Needs review » Reviewed & tested by the community

@Ryo Yamashita @yas
Thank you for providing the patch. I tested that it works as expected and it worked.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@asahi.noriaki

Thank you for you review.

@ryo-yamashita

I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@ryo-yamashita

Can you please rebase the patch? Thanks!

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I rebased this patch. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Sorry, due to the prior merge, can you please rebase the patch again? Thanks!

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix an error that the message to download private key is not displayed after creating a key pair in SPA » Fix an error where the message to download an SSH private key is not displayed after creating the OpenStack key pair in SPA

  • yas committed bd499229 on 6.x authored by Ryo Yamashita 
    Issue #3366345 by Ryo Yamashita, yas, asai.noriaki: Fix an error where...

  • yas committed 8f2ba35e on 5.x authored by Ryo Yamashita 
    Issue #3366345 by Ryo Yamashita, yas, asai.noriaki: Fix an error where...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.