Twig 3 does not use the inline conditional like:
{% for key, item in array if key|first != '#' %}
....
Open layout builder and add some of this blocks you'll get error.
Use condition as an if statement.
Instead of
{% for key, item in array if key|first != '#' %}
Use
{% for key, item in array %}
{% if key|first != '#' %}
....
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | 3366333-accordion-block-filter-counter.png | 87.43 KB | hfernandes |
| #9 | 3366333-accordion-block-if-counter.png | 103.34 KB | hfernandes |
| #6 | 3366333-add-accordion-block.png | 394.18 KB | carolpettirossi |
| #5 | 16.diff | 10.96 KB | tpzurdo |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes, plain diff MR !16changes, plain diff MR !15
Comments
Comment #4
tpzurdo commentedComment #5
tpzurdo commentedComment #6
carolpettirossi commentedI also faced this issue when I tried to create an Accordion Block.
I applied patch #5, and it solved the issue.
Comment #9
hfernandes commentedI noticed that with the `if`, the `loop.index` wasn't counting correctly, so I changed it to use the `filter` filter instead.
Here is one example, the first accordion item should be open by default. With the `if` approach, it wasn't. The item counter starts with 16.
Using `filter`, the first item is open and the counter is 1:
Moving it back to `Needs Review`.
Comment #10
aaronchristian commentedAhhh nice catch @ tpzurdo.
Thanks @carolpettirossi and @hfernandes, yep confirmed that this morning.
Thanks for the contributions back everyone.
Marking as RTBC, and I'll get this one merged into dev as well.
Comment #11
aaronchristian commentedComment #12
aaronchristian commented