Problem/Motivation
FILE: ...l/vb/d_cont/simple_sitemap_page_manager/simple_sitemap_page_manager.module
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
9 | WARNING | [x] Unused use statement
12 | WARNING | [ ] Doc comment indicates hook_form_alter() but function
| | signature is
| | "simple_sitemap_page_manager_form_page_manage_variant_configure_form_alter"
| | instead of "simple_sitemap_page_manager_form_alter". Did
| | you mean hook_form_FORM_ID_alter()?
53 | WARNING | [ ] #description values usually have to run through t() for
| | translation
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...imple_sitemap_page_manager/src/Controller/SimpleSitemapPagesController.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
30 | ERROR | Parameter $settings is not described in comment
33 | ERROR | Doc comment for parameter $form_helper does not match actual
| | variable name $settings
--------------------------------------------------------------------------------
FILE: ...ml/vb/d_cont/simple_sitemap_page_manager/src/SimpleSitemapPagesManager.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the class does and
| | not simply repeat the class name
--------------------------------------------------------------------------------
FILE: ..._page_manager/src/Plugin/simple_sitemap/UrlGenerator/PagesUrlGenerator.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------
49 | ERROR | [ ] Parameter $settings is not described in comment
58 | ERROR | [ ] Doc comment for parameter $generator does not match actual
| | variable name $pages_manager
103 | ERROR | [x] Expected 1 space before opening brace; found 2
156 | ERROR | [x] Expected 1 space before opening brace; found 2
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 113ms; Memory: 10MB
Steps to reproduce
Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig simple_sitemap_page_manager/
Proposed resolution
Fix the issues reported for Drupal and DrupalPractice coding standards
Remaining tasks
Patch Review
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | coding-standard-fixes-3.patch | 5.25 KB | arpitk |
| #5 | simple_sitemap_page_manager Screenshot 3366174 after patch.png | 31.32 KB | arpitk |
| #5 | simple_sitemap_page_manager Screenshot 3366174 before patch.png | 99.63 KB | arpitk |
| coding-standard-fixes.patch | 4.2 KB | urvashi_vora |
Comments
Comment #2
arpitk commentedReviewing this.
Comment #3
jay jangid commentedComment #4
jay jangid commentedHey @arpitk Thanks for your patch.
After applied patch , all phpcs issues are resolved.
Thank you.
Comment #5
arpitk commentedHi @urvashi_vora I reviewed the patch. After applying the patch few errors in simple_sitemap_page_manager.module are reported. Attaching before and after patch results. I have fixed those errors and updated the patch. Please review.
Thanks!
Comment #6
murilohp commentedThanks for your contribution @Jay Jangid, @arpitk and @urvashi_vora, I've reviewed the patch and looks good to me
Comment #7
murilohp commentedComment #9
murilohp commentedCommited to 2.0.x, thanks!