Hey guys! Thanks for this amazing module. Do you plan to make it D10 compatible soon? Thanks!

Issue fork php_ffmpeg-3365929

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DudeWeb created an issue. See original summary.

arturopanetta made their first commit to this issue’s fork.

arturopanetta opened merge request !4

arturopanetta’s picture

arturopanetta
Primary language Italian
Location Grotteria (RC)
commented
Status: Active » Needs review

I sent a merge request to make this module D10 compliant. The code sent also contains patch #9 of #3256578, I had to insert patch #3256578 #9 as the code I sent would not work on Drupal 10. Also patch #9 I had to modify to make it work with D10.
The rest should go smoothly.

Bhanu951 made their first commit to this issue’s fork.

bhanu951’s picture

bhanu951 commented

Added D10 compatibility in Composer.json.

jojo_martin made their first commit to this issue’s fork.

jojo_martin opened merge request !5

jojo_martin’s picture

jojo_martin commented

When using the work from https://git.drupalcode.org/project/php-ffmpeg/-/merge_requests/4 I ran into errors and noticed some refactored functions were missing return statements, so I made https://git.drupalcode.org/project/php-ffmpeg/-/merge_requests/5 and it seems to work well enough to get by now. It feels weird to make a new merge request since this is building off of an existing merge request, but this seemed to be the best option to get the fix accessible to grab as a patch for now.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Closed (duplicate)

Committed D10 changes as part of #3256578: Incompatible with newest version of the php-ffmpeg (v0.19.0) package, Drupal 10 compatibility, as far as I could see there was nothing here that was needed on top of the generated patch in #3297867: Automated Drupal 10 compatibility fixes.