Problem/Motivation
FILE: /var/www/html/vb/d_cont/cna/cna.module
--------------------------------------------------------------------------------
FOUND 46 ERRORS AND 2 WARNINGS AFFECTING 30 LINES
--------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
7 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
| | "* Implements hook_foo_BAR_ID_bar() for block templates."
7 | ERROR | [x] Doc comment short description must end with a full stop
8 | ERROR | [x] There must be no blank lines after the function comment
12 | ERROR | [x] Expected 1 space after IF keyword; 0 found
12 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
13 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
16 | ERROR | [x] Expected 1 space before "="; 0 found
18 | ERROR | [x] Expected 1 space before "="; 0 found
19 | ERROR | [x] Expected 1 space before "="; 0 found
19 | ERROR | [x] Expected 1 space after "="; 0 found
19 | ERROR | [x] Concat operator must be surrounded by a single space
19 | ERROR | [x] Concat operator must be surrounded by a single space
20 | ERROR | [x] Expected 1 space before "="; 0 found
21 | ERROR | [x] Comments may not appear after statements
21 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
| | question marks, colons, or closing parentheses
24 | ERROR | [x] Expected 1 space before "=>"; 0 found
25 | ERROR | [x] Expected 1 space before "=>"; 0 found
25 | ERROR | [x] Expected 1 space after "=>"; 0 found
27 | ERROR | [x] Expected one space after the comma, 0 found
33 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements
| | hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "*
| | Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
| | "* Implements hook_foo_BAR_ID_bar() for block templates."
34 | ERROR | [x] Doc comment short description must end with a full stop
34 | ERROR | [ ] Doc comment short description must be on a single line,
| | further text should be a separate paragraph
35 | ERROR | [x] There must be no blank lines after the function comment
37 | ERROR | [x] Expected 1 space before opening brace; found 0
39 | ERROR | [x] Expected 1 space after IF keyword; 0 found
39 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
40 | ERROR | [x] Expected 1 space after IF keyword; 0 found
40 | ERROR | [x] Space found before object operator
40 | ERROR | [x] Space found after object operator
40 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
43 | ERROR | [x] Expected 1 space before "="; 0 found
45 | ERROR | [x] Expected 1 space before "="; 0 found
46 | ERROR | [x] Expected 1 space before "="; 0 found
46 | ERROR | [x] Expected 1 space after "="; 0 found
46 | ERROR | [x] Concat operator must be surrounded by a single space
46 | ERROR | [x] Concat operator must be surrounded by a single space
47 | ERROR | [x] Expected 1 space before "="; 0 found
48 | ERROR | [x] Comments may not appear after statements
48 | ERROR | [x] Inline comments must end in full-stops, exclamation marks,
| | question marks, colons, or closing parentheses
51 | ERROR | [x] Expected 1 space before "=>"; 0 found
52 | ERROR | [x] Expected 1 space before "=>"; 0 found
52 | ERROR | [x] Expected 1 space after "=>"; 0 found
54 | ERROR | [x] Expected one space after the comma, 0 found
63 | ERROR | [x] Expected one space after the comma, 0 found
83 | ERROR | [x] Expected one space after the comma, 0 found
91 | ERROR | [x] Expected 1 space before "=>"; 0 found
91 | ERROR | [x] Expected 1 space after "=>"; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 45 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: /var/www/html/vb/d_cont/cna/cna.info.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------
1 | WARNING | [ ] Remove "version" from the info file, it will be added by
| | drupal.org packaging automatically
9 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: /var/www/html/vb/d_cont/cna/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------
14 | WARNING | [ ] Line exceeds 80 characters; contains 201 characters
24 | WARNING | [ ] Line exceeds 80 characters; contains 175 characters
30 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
51 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------
FILE: /var/www/html/vb/d_cont/cna/src/Form/CNAConfig.php
------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
71 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
Time: 76ms; Memory: 10MB
Steps to reproduce
Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig cna/
Proposed resolution
Fix all the reported issues for Drupal and DrupalPractice coding standards
Remaining tasks
Patch Review
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | phpcodingstandard-fixed.png | 194.73 KB | a.aaronjake |
| #2 | before patch.png | 269.17 KB | anjali mehta |
| #2 | after patch.png | 32.82 KB | anjali mehta |
| coding-standard-fixes.patch | 6.6 KB | urvashi_vora |
Issue fork cna-3365575
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3365575-fix-the-issues
changes, plain diff MR !2
- 1.0.x
changes, plain diff MR !3
Comments
Comment #2
anjali mehta commentedHello @urvashi_vora ,
I have reviewed your patch on drupal version 9.5.9 And PHP version - 8.1
I am adding some screenshots(before/after applying the patch) for your reference.
Please have a look at these screenshots.
Thank You.
Comment #8
a.aaronjake commentedHi @everyone,
Php coding standards are now fixed. Please see attached screenshot.
Will now move this to RTBC.
Thanks,
Jake
Comment #9
gowthamrajkrishnasamy commentedComment #10
gowthamrajkrishnasamy commentedComment #11
gowthamrajkrishnasamy commented