Problem/Motivation
FILE: ...r/www/html/vb/d_cont/scheduler_request_cron/scheduler_request_cron.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------
FILE: /var/www/html/vb/d_cont/scheduler_request_cron/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
9 | WARNING | Line exceeds 80 characters; contains 83 characters
12 | WARNING | Line exceeds 80 characters; contains 133 characters
13 | WARNING | Line exceeds 80 characters; contains 96 characters
----------------------------------------------------------------------
FILE: ...vb/d_cont/scheduler_request_cron/src/EventSubscriber/RequestSubscriber.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
55 | WARNING | Line exceeds 80 characters; contains 87 characters
--------------------------------------------------------------------------------
Time: 74ms; Memory: 10MB
Steps to reproduce
Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig scheduler_request_cron/
Proposed resolution
Fix all the issues reported for Drupal and DrupalPractice coding standards
Remaining tasks
Patch Review
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Screenshot from 2023-06-08 18-23-00.png | 34.52 KB | raveen_thakur51 |
| #2 | with patch.png | 129.49 KB | kenyoowen |
| #2 | wihout patch.png | 197.21 KB | kenyoowen |
| coding-standard-fixes.patch | 1.73 KB | urvashi_vora |
Issue fork scheduler_request_cron-3365563
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
kenyoowen commentedHi urvashi_vora
I reviewed and applied your patch and confirmed that the issues mentioned are resolved.
Please see the screenshots attached.
Thank you.
Comment #3
raveen_thakur51 commentedHii, I have reviewed & implemented the #patch. The #patch seems to resolve all phpcs-related issues. I am adding a screenshot for reference. And Thank you.
Comment #4
pvbergen commentedComment #5
pvbergen commentedComment #6
pvbergen commentedPlease provide the changes using the issue fork and a merge request.
Comment #8
raveen_thakur51 commentedCreated MR! PLease review
Comment #9
raveen_thakur51 commentedComment #10
avpadernoComment #11
imustakim commentedComment #12
imustakim commentedMR updated.
Please review.
Comment #13
pvbergen commentedComment #14
pvbergen commentedComment #15
pvbergen commented