Problem/Motivation

FILE: ...r/www/html/vb/d_cont/scheduler_request_cron/scheduler_request_cron.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------

FILE: /var/www/html/vb/d_cont/scheduler_request_cron/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
9 | WARNING | Line exceeds 80 characters; contains 83 characters
12 | WARNING | Line exceeds 80 characters; contains 133 characters
13 | WARNING | Line exceeds 80 characters; contains 96 characters
----------------------------------------------------------------------

FILE: ...vb/d_cont/scheduler_request_cron/src/EventSubscriber/RequestSubscriber.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
55 | WARNING | Line exceeds 80 characters; contains 87 characters
--------------------------------------------------------------------------------

Time: 74ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig scheduler_request_cron/

Proposed resolution

Fix all the issues reported for Drupal and DrupalPractice coding standards

Remaining tasks

Patch Review

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

urvashi_vora created an issue. See original summary.

kenyoowen’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new197.21 KB
new129.49 KB

Hi urvashi_vora

I reviewed and applied your patch and confirmed that the issues mentioned are resolved.

Please see the screenshots attached.
Thank you.

raveen_thakur51’s picture

StatusFileSize
new34.52 KB

Hii, I have reviewed & implemented the #patch. The #patch seems to resolve all phpcs-related issues. I am adding a screenshot for reference. And Thank you.

pvbergen’s picture

Version: 1.x-dev » 2.x-dev
pvbergen’s picture

Status: Reviewed & tested by the community » Needs work
pvbergen’s picture

Please provide the changes using the issue fork and a merge request.

raveen_thakur51’s picture

Created MR! PLease review

raveen_thakur51’s picture

Status: Needs work » Needs review
avpaderno’s picture

Priority: Normal » Minor
Status: Needs review » Needs work
imustakim’s picture

Assigned: Unassigned » imustakim
imustakim’s picture

Assigned: imustakim » Unassigned
Status: Needs work » Needs review

MR updated.
Please review.

pvbergen’s picture

Status: Needs review » Reviewed & tested by the community
pvbergen’s picture

Status: Reviewed & tested by the community » Fixed
pvbergen’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.