Problem/Motivation

  • Fix the problem and make the 'Add launch template' button appear on the screen.
  • Note: This patch does not create a REST API.

Issue fork cloud-3365226

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1824

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the patch. Can you please fix the following coding standards errors?

FILE: .../html/web/modules/contrib/cloud/src/Controller/ApiController.php
----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
  94 | ERROR | [x] Case breaking statements must be followed by a
     |       |     single blank line
 113 | ERROR | [x] Whitespace found at end of line
 116 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------

Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add the button to create launch template in SPA » Add a button to create OpenStack launch template in SPA
Category: Task » Bug report
ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I fixed code for coding standards and merge commits. Please review it again. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@ryo-yamashita

Can you fix the following coding standards errors, too?

FILE: ...r/docroot/modules/contrib/cloud/src/Controller/ApiController.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 114 | ERROR | [x] Whitespace found at end of line
 117 | ERROR | [x] Whitespace found at end of line
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Thanks

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I re-fixed code for coding standards and merge commits. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. It looks good to me now. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed da7dfca6 on 6.x authored by Ryo Yamashita 
    Issue #3365226 by Ryo Yamashita, yas: Add a button to create OpenStack...

  • yas committed 43adbdca on 5.x authored by Ryo Yamashita 
    Issue #3365226 by Ryo Yamashita, yas: Add a button to create OpenStack...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.