Problem/Motivation

  • Refactor DMore\ChromeDriver\DevToolsConnection (DevToolsConnection.php)

Issue fork cloud-3364689

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

asai.noriaki created an issue. See original summary.

asai.noriaki opened merge request !1818

asai.noriaki’s picture

asai.noriaki commented
Status: Active » Needs review

@yas

Could you please review the patch?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@asai.noriaki

Thank you for the refactoring. It looks good to me. I'll merge the patch to 5.x and 6.x, and close this issue as Fixed.

  • yas committed 11450be9 on 6.x authored by asai.noriaki 
    Issue #3364689 by asai.noriaki, yas: Refactor DMore\ChromeDriver\...

  • yas committed 1aefeb25 on 5.x authored by asai.noriaki 
    Issue #3364689 by asai.noriaki, yas: Refactor DMore\ChromeDriver\...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.