Closed (fixed)
Project:
Search and Replace Scanner
Version:
2.0.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
2 Jun 2023 at 13:59 UTC
Updated:
19 Aug 2026 at 15:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
smustgrave commentedComment #4
smustgrave commentedTook a crack at it with an opinionated approach for sure.
Comment #5
smustgrave commentedDisclosure used claude to fix the tests but it does look cleaner.
Comment #6
smustgrave commentedComment #9
smustgrave commentedRebased
Comment #10
damienmckennaThis is a good improvement, thank you.
A few minor items:
* I don't think the form classes need to include "Scanner" in their names, I think the names could be simplified.
* It might be worth naming the new path "entities" rather than "entity-scope", which is overly verbose IMHO.
* An empty hook_update_N() might be needed to force sites to rebuild the caches, so the new routes & menu items are picked up.
Comment #11
smustgrave commentedAll makes sense to me
Comment #12
smustgrave commentedDid points 2 + 3 but for 1 I actually looked around and most modules have the name of the module in the form name so don't think we should drop scanner but open to other suggestions.
Comment #13
smustgrave commented