Closed (fixed)
Project:
Bootstrap Basic Image Gallery
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
31 May 2023 at 17:54 UTC
Updated:
26 Aug 2024 at 12:36 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jsacksick commentedComment #3
aleixI was working on it too, so despite there's a patch too, I am adding a new patch, It covers media hover preview too.
Comment #4
jsacksick commentedoh! First tried the forEach approach and experienced issues, didn't realize the order of parameters changed there (index and item), my patch covered the preview too?
Comment #5
aleixI see now, sorry. I thought that it didn't cover the media hover_preview_media, but it does.
It's on maintainer's hands to choose.
As contextual info for maintainer , here the cr: https://www.drupal.org/node/3158256
Comment #6
niki v commentedTrying to update this module as part of a local Commerce Kickstart install via composer and the patch keeps failing
I'm not sure whether this is related but my local install then has the following error
If this is actually a kickstart problem, I'll open an issue there but this is the only aspect of the entire scaffold update that fails consistently
Comment #7
keshavv commentedModule already released to Drupal 10. But still
.once()is not replaced.Patch #3 works well to fix
jQuery.once()issue.Please merge this patch so at least we can unblock this issue.
Comment #9
daniel.moberly commentedComment #11
kazimir31293 commentedRun
```
composer create-project -s dev centarro/commerce-kickstart-project drupalcommerce
```
have got this
```
- Applying patches for drupal/bootstrap_basic_image_gallery
https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch (#3363948 - Fix D10 compatibility issues)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch
In Patches.php line 331:
Cannot apply patch #3363948 - Fix D10 compatibility issues (https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch)!
```
Comment #12
niki v commentedIt's been a while since I solved his so I don't remember exactly how I did it but patch failures for me were a windows permission error or similar on WAMP server. If that applies to you, Google is your friend. If not WAMP, it's a composer issue
Comment #13
gresko8 commentedThis fix has been out for some time but only in the dev version. Since it's solving D10 compatibility issues it would be nice to have it in an official release.