Problem/Motivation

There are multiple JS errors when using this module on D10, the attached patch seems to fix them.

CommentFileSizeAuthor
#3 3363948-3.patch2.96 KBaleix
#2 3363948-2.patch2.36 KBjsacksick

Comments

jsacksick created an issue. See original summary.

jsacksick’s picture

Status: Active » Needs review
StatusFileSize
new2.36 KB
aleix’s picture

StatusFileSize
new2.96 KB

I was working on it too, so despite there's a patch too, I am adding a new patch, It covers media hover preview too.

jsacksick’s picture

oh! First tried the forEach approach and experienced issues, didn't realize the order of parameters changed there (index and item), my patch covered the preview too?

aleix’s picture

I see now, sorry. I thought that it didn't cover the media hover_preview_media, but it does.
It's on maintainer's hands to choose.

As contextual info for maintainer , here the cr: https://www.drupal.org/node/3158256

niki v’s picture

Trying to update this module as part of a local Commerce Kickstart install via composer and the patch keeps failing

Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch

I'm not sure whether this is related but my local install then has the following error

Error: Failed opening required 'C:\wamp64\www\kickstart\web/../vendor/autoload.php' (include_path='.;C:\php\pear') in C:\wamp64\www\kickstart\web\autoload.php on line 16

If this is actually a kickstart problem, I'll open an issue there but this is the only aspect of the entire scaffold update that fails consistently

keshavv’s picture

Status: Needs review » Reviewed & tested by the community

Module already released to Drupal 10. But still .once() is not replaced.
Patch #3 works well to fix jQuery.once() issue.
Please merge this patch so at least we can unblock this issue.

daniel.moberly’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kazimir31293’s picture

Run

```
composer create-project -s dev centarro/commerce-kickstart-project drupalcommerce
```

have got this

```
- Applying patches for drupal/bootstrap_basic_image_gallery
https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch (#3363948 - Fix D10 compatibility issues)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch

In Patches.php line 331:

Cannot apply patch #3363948 - Fix D10 compatibility issues (https://www.drupal.org/files/issues/2023-06-01/3363948-3.patch)!

```

niki v’s picture

It's been a while since I solved his so I don't remember exactly how I did it but patch failures for me were a windows permission error or similar on WAMP server. If that applies to you, Google is your friend. If not WAMP, it's a composer issue

gresko8’s picture

This fix has been out for some time but only in the dev version. Since it's solving D10 compatibility issues it would be nice to have it in an official release.