After upgrading to d10

TypeError: Drupal\redirect_after_logout\EventSubscriber\RedirectAfterLogoutSubscriber::checkRedirection(): Argument #1 ($event) must be of type Symfony\Component\HttpKernel\Event\FilterResponseEvent, Symfony\Component\HttpKernel\Event\ResponseEvent given in Drupal\redirect_after_logout\EventSubscriber\RedirectAfterLogoutSubscriber->checkRedirection() (line 41 of modules/contrib/redirect_after_logout/src/EventSubscriber/RedirectAfterLogoutSubscriber.php).
call_user_func() (Line: 111)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch() (Line: 196)
Symfony\Component\HttpKernel\HttpKernel->filterResponse() (Line: 184)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 74)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 58)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 686)
Drupal\Core\DrupalKernel->handle() (Line: 19)
CommentFileSizeAuthor
#7 3362821-4.patch1.04 KBprabuela
#5 3362821-3.patch1.13 KBprabuela
#2 redirect_after_logout_3362821_2.patch772 bytesgigimaor

Issue fork redirect_after_logout-3362821

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gigimaor created an issue. See original summary.

gigimaor’s picture

gigimaor
må-or
Location Narangba/Brisbane
commented
StatusFileSize
new redirect_after_logout_3362821_2.patch772 bytes
gigimaor’s picture

gigimaor
må-or
Location Narangba/Brisbane
commented
Issue summary: View changes
prabuela’s picture

prabuela commented
Assigned: Unassigned » prabuela
prabuela’s picture

prabuela commented
StatusFileSize
new 3362821-3.patch1.13 KB
prabuela’s picture

prabuela commented
prabuela’s picture

prabuela commented
StatusFileSize
new 3362821-4.patch1.04 KB

bharath-kondeti made their first commit to this issue’s fork.

bharath-kondeti opened merge request !3

bharath-kondeti’s picture

bharath-kondeti commented
Status: Active » Needs review

Patch failed to apply. Made the changes, raised an MR for review.

prabuela’s picture

prabuela commented
prabuela’s picture

prabuela commented
Assigned: prabuela » Unassigned
nevergone’s picture

nevergone
Primary language Hungarian
commented

merge request !3 review:

@@ -111,10 +111,10 @@ class RedirectAfterLogoutSubscriber implements EventSubscriberInterface {
   /**
    * Check redirection.
    *
-   * @param \Symfony\Component\HttpKernel\Event\ResponseEvent $event
+   * @param \Symfony\Component\HttpKernel\Event\FilterResponseEvent $event
    *   Event.
    */
-  public function checkRedirection(ResponseEvent $event) {
+  public function checkRedirection(FilterResponseEvent $event) {

FilterResponseEvent is deprecated in Drupal 9.x:

/**
 * @deprecated since Symfony 4.3, use ResponseEvent instead
 */

This issue is fixed in 8.x-1.x branch, and fixed 8.x-1.3 release. Please test, thanks.

nevergone’s picture

nevergone
Primary language Hungarian
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.