Problem/Motivation

When custom_elements module gets uninstalled we need to ensure all entity_ce_display entities are properly deleted. Theoretically, it must be done if config dependencies are properly set.

On bundle delete we need to delete also entity_ce_display entities for this entity/bundle. Something similar must already be implemented in core.

Proposed resolution

Check and try to reuse solutions from the core before bringing extra code to the project.

Comments

mostepaniukvm created an issue. See original summary.

mostepaniukvm’s picture

mostepaniukvm
he/him
commented
Related issues: +#3359601: custom_elements_ui: re-implement with new concept
junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented
Assigned: Unassigned » junkuncz
junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented

Are you sure we need to do anything about it? I was doing some testing and looks like entity_ce_display config object is deleted automatically during bundle delete and if I uninstall the module all related configs are removed.
Maybe we could add a tiny snippet to hook_uninstall() to make sure all entity_ce_display configs are properly deleted. Something like this:

  $storage = \Drupal::service('entity_type.manager')->getStorage('entity_ce_display');
  $configs = $storage->loadMultiple();
  if (!empty($configs)) {
    $storage->delete($configs);
  }

What do you think?

junkuncz’s picture

junkuncz
Primary language Hungarian
Location Budapest
commented
Assigned: junkuncz » Unassigned
Status: Active » Needs review
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

I don't think this is needed, if config dependencies are doing the clean-up correctly, it's fine to rely on that. Thanks for checking!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.